Project

General

Profile

Feature #13145

rewrite amdf17nbdf to use the ksensor framework

Added by Robert Mustacchi 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

As part of the refactoring we're doing in #13144, we're separating amdf17nbdf into a nexus driver and a separate temperature sensor driver. As part of this we should make sure that the resulting new driver, smntemp uses the ksensor framework, simplifying the driver in the process.

#1

Updated by Electric Monk 7 months ago

  • Gerrit CR set to 940
#2

Updated by Robert Mustacchi 6 months ago

I've tested this by looking at the temperature data on a Zen 1 2P Naples system and a 1P Zen 2 Rome system and verifying that the reported temperatures are in line with what ipmitool said. I verified that on the Zen 1 system we still had the 4 instances per system.

#3

Updated by Electric Monk 6 months ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 047043c2181e939608ea2c09257fd2d515e99643

commit  047043c2181e939608ea2c09257fd2d515e99643
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-10-21T21:02:57.000Z

    13144 refactor amdf17nbdf into a nexus
    13145 rewrite amdf17nbdf to use the ksensor framework
    13146 Want a driver for AMD SMN user access
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Reviewed by: Mike Zeller <mike.zeller@joyent.com>
    Reviewed by: Robert French <robert@robertdfrench.me>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF