Project

General

Profile

Actions

Bug #13147

open

bhyve kernel could make more use of bitset()

Added by Patrick Mooney about 3 years ago. Updated 7 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
bhyve
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
bhyve
Gerrit CR:
External Bug:

Description

As jclulow pointed out in a bhyve-related code review, BITX is a convenient macro for extracting runs of bits from fields.
There are numerous cases where raw bit math is being done in the bhyve kernel today which could be replaced by more readable BITX expressions.

Update: With the addition of the bitset*() and bitx*() functions as part of #14727, it makes more sense to use those bounds-checked functions, rather than the macros.


Related issues

Related to illumos gate - Bug #13139: bhyve bungles math for VMX ins/outs sizeClosedPatrick Mooney

Actions
Actions #1

Updated by Patrick Mooney about 3 years ago

  • Related to Bug #13139: bhyve bungles math for VMX ins/outs size added
Actions #2

Updated by Patrick Mooney 7 months ago

  • Subject changed from bhyve kernel could make more use of BITX() to bhyve kernel could make more use of bitset()
  • Description updated (diff)
Actions

Also available in: Atom PDF