Actions
Feature #13166
closed
Support en_fec_cap and adv_fec_cap link properties in i40e
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
Following on from #13165 we should also support en_fec_cap and adv_fec_cap link properties in i40e
Related issues
Updated by Paul Winder about 3 years ago
- Related to Bug #13165: FEC enabled port connected to i40e may not come online added
Updated by Paul Winder about 3 years ago
Testing¶
1. Properties on non-FEC capable device¶
All properties are read-only
# dladm show-linkprop -p en_fec_cap,adv_fec_cap i40e1 LINK PROPERTY PERM VALUE DEFAULT POSSIBLE i40e1 en_fec_cap r- -- r- none,auto,rs,base-r i40e1 adv_fec_cap r- none none none,auto,rs,base-r
2. Properties on FEC capable device¶
en_fec_cap can be used to change FEC mode.
# dladm show-linkprop -p en_fec_cap,adv_fec_cap i40e5 LINK PROPERTY PERM VALUE DEFAULT POSSIBLE i40e5 en_fec_cap rw auto auto none,auto,rs,base-r i40e5 adv_fec_cap r- base-r auto none,auto,rs,base-r
3. Setting to a FEC mode supported by the switch port¶
# dladm set-linkprop -t -p en_fec_cap=base-r i40e5 # dladm show-linkprop -p en_fec_cap,adv_fec_cap i40e5 LINK PROPERTY PERM VALUE DEFAULT POSSIBLE i40e5 en_fec_cap rw base-r auto none,auto,rs,base-r i40e5 adv_fec_cap r- base-r auto none,auto,rs,base-r # dladm set-linkprop -t -p en_fec_cap=base-r,rs i40e5 # dladm show-linkprop -p en_fec_cap,adv_fec_cap i40e5 LINK PROPERTY PERM VALUE DEFAULT POSSIBLE i40e5 en_fec_cap rw rs,base-r auto none,auto,rs,base-r i40e5 adv_fec_cap r- base-r auto none,auto,rs,base-r # dladm set-linkprop -t -p en_fec_cap=auto i40e5 # dladm show-linkprop -p en_fec_cap,adv_fec_cap i40e5 LINK PROPERTY PERM VALUE DEFAULT POSSIBLE i40e5 en_fec_cap rw auto auto none,auto,rs,base-r i40e5 adv_fec_cap r- base-r auto none,auto,rs,base-r
In all cases the link stayed up
# dladm show-phys i40e5 LINK MEDIA STATE SPEED DUPLEX DEVICE i40e5 Ethernet up 25000 full i40e5
4. Setting to a FEC mode not support by the switch port¶
# dladm set-linkprop -t -p en_fec_cap=rs i40e5 # dladm show-linkprop -p en_fec_cap,adv_fec_cap i40e5 LINK PROPERTY PERM VALUE DEFAULT POSSIBLE i40e5 en_fec_cap rw rs auto none,auto,rs,base-r i40e5 adv_fec_cap r- none auto none,auto,rs,base-r
The link is down
# dladm show-phys i40e5 LINK MEDIA STATE SPEED DUPLEX DEVICE i40e5 Ethernet down 0 unknown i40e5
5. Setting back to a supported FEC mode¶
# dladm set-linkprop -t -p en_fec_cap=base-r i40e5 # dladm show-linkprop -p en_fec_cap,adv_fec_cap i40e5 LINK PROPERTY PERM VALUE DEFAULT POSSIBLE i40e5 en_fec_cap rw base-r auto none,auto,rs,base-r i40e5 adv_fec_cap r- base-r auto none,auto,rs,base-r # dladm show-phys i40e5 LINK MEDIA STATE SPEED DUPLEX DEVICE i40e5 Ethernet up 25000 full i40e5
Updated by Electric Monk about 3 years ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
git commit 11a004840daff945cd5e382eeb137e0682eabe1f
commit 11a004840daff945cd5e382eeb137e0682eabe1f
Author: Paul Winder <pwinder@racktopsystems.com>
Date: 2020-09-28T15:54:44.000Z
13165 FEC enabled port connected to i40e may not come online
13166 Support en_fec_cap and adv_fec_cap link properties in i40e
Reviewed by: Robert Mustacchi <rm@fingolfin.org>
Reviewed by: Ryan Zezeski <ryan@zinascii.com>
Reviewed by: Igor Kozhukhov <igor@dilos.org>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions