Project

General

Profile

Bug #13168

reality should reflect the mac_prop_id_t comment

Added by Robert Mustacchi 7 days ago. Updated 4 days ago.

Status:
Closed
Priority:
Normal
Category:
networking
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

There's a comment at the top of the mac_prop_id_t enumeration:

...
* Please append properties to the end of this list. Do not reorder the list.
...

However, the last entry in it right now is MAC_PROP_PRIVATE = -1. If one actually followed the instruction and placed it at the actual end, that'd do the wrong thing. Instead, we should just put it at the top so that way the instructions can remain valid and reduce the risk of someone doing something wrong in the future.

To test this, I ran a wsdiff, and the only thing that's not in the noise was the change to the mac header itself. Everything else was identical, which is what we'd expect. I also used ctfdump -c to dump the mac kernel module to verify that the CTF was similar. The only difference was the order of the enumerations, but the values of the enumeration itself did not change.

History

#1

Updated by Robert Mustacchi 7 days ago

  • Description updated (diff)
#2

Updated by Electric Monk 7 days ago

  • Gerrit CR set to 939
#3

Updated by Electric Monk 4 days ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit fd147c98dbdbc9e5ac99fa51cb608e8eeb1f16f1

commit  fd147c98dbdbc9e5ac99fa51cb608e8eeb1f16f1
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-09-18T15:05:43.000Z

    13168 reality should reflect the mac_prop_id_t comment
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Also available in: Atom PDF