reality should reflect the mac_prop_id_t comment
There's a comment at the top of the
... * Please append properties to the end of this list. Do not reorder the list. ...
However, the last entry in it right now is
MAC_PROP_PRIVATE = -1. If one actually followed the instruction and placed it at the actual end, that'd do the wrong thing. Instead, we should just put it at the top so that way the instructions can remain valid and reduce the risk of someone doing something wrong in the future.
To test this, I ran a wsdiff, and the only thing that's not in the noise was the change to the mac header itself. Everything else was identical, which is what we'd expect. I also used
ctfdump -c to dump the mac kernel module to verify that the CTF was similar. The only difference was the order of the enumerations, but the values of the enumeration itself did not change.
Updated by Electric Monk 12 months ago
- Status changed from New to Closed
- % Done changed from 90 to 100
commit fd147c98dbdbc9e5ac99fa51cb608e8eeb1f16f1 Author: Robert Mustacchi <firstname.lastname@example.org> Date: 2020-09-18T15:05:43.000Z 13168 reality should reflect the mac_prop_id_t comment Reviewed by: Dan McDonald <email@example.com> Reviewed by: Patrick Mooney <firstname.lastname@example.org> Reviewed by: Toomas Soome <email@example.com> Approved by: Hans Rosenfeld <firstname.lastname@example.org>