Project

General

Profile

Bug #13211

mdb ::prtusb truncates some addresses

Added by Brian Bennett 20 days ago. Updated 9 days ago.

Status:
Closed
Priority:
Normal
Category:
mdb - modular debugger
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Several addresses are printed as %x when they should be %lx.

#1

Updated by Brian Bennett 20 days ago

Some examples:

> ::prtusb -vt ! grep dip
  dip: 0xe0f9f878
      dip: 0xe8f9b608
          dip: 0xe8f9b338
      dip: 0xf1b88350
          dip: 0xf1b888f0
          dip: 0x31c73358
  dip: 0xe8f9b608
      dip: 0xe8f9b338
  dip: 0xf1b88350
      dip: 0xf1b888f0
      dip: 0x31c73358
> ::prtusb -vt ! grep statep
      scsa2usb_statep: 0xeb4cd000
      scsa2usb_statep: 0xe1541000
  scsa2usb_statep: 0xeb4cd000
  scsa2usb_statep: 0xe1541000
> ::prtusb -vt ! grep usba_device
usba_device: 0xeac79000
usba_device: 0xeaf82b00
usba_device: 0x36308080
#2

Updated by Robert Mustacchi 20 days ago

  • Category set to mdb - modular debugger
  • Assignee set to Robert Mustacchi
  • % Done changed from 0 to 80
#3

Updated by Electric Monk 20 days ago

  • Gerrit CR set to 965
#4

Updated by Robert Mustacchi 16 days ago

To test this I ran through the ::prtusb -vt output on a system of mine and went through it to make sure that all of the addresses I noticed were fully written out.

#5

Updated by Electric Monk 9 days ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit cbabcf308eac89bf8ef60ef05c5cff192e2d7e7e

commit  cbabcf308eac89bf8ef60ef05c5cff192e2d7e7e
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-10-20T15:47:36.000Z

    13211 mdb ::prtusb truncates some addresses
    Reviewed by: Brian Bennett <brian.bennett@joyent.com>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF