Project

General

Profile

Actions

Feature #13217

closed

Allow building with python 3.9

Added by Andy Fiddaman 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
packaging
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Building with python 3.9 currently fails the rtime check as the exception list only covers up to version 3.8

Actions #1

Updated by Electric Monk 7 months ago

  • Gerrit CR set to 971
Actions #2

Updated by Andy Fiddaman 7 months ago

Tested running each of:

  • mapfilechk
  • wsdiff
  • cddlchk
  • git-pbchk
  • hdrchk
  • wscheck
  • crightchk.py
  • validate_pkg

under Python 3.9, 3.7 and 2.7

Confirmed that even 2.7 supports the new threading.is_alive() method, the previous isAlive() being formally deprecated in 3.8 and removed in 3.9

(The wsdiff test confirms this but just for completeness):

Python 2.7.18 (default, Oct 11 2020, 16:42:09)
[GCC 9.3.0] on sunos5
Type "help", "copyright", "credits" or "license" for more information.
>>> import time, threading
>>> def worker(): time.sleep(3600)
...
>>> t = threading.Thread(target=worker)
>>> t.isAlive()
False
>>> t.is_alive()
False
>>> t.start()
>>> t.isAlive()
True
>>> t.is_alive()
True
>>>
Actions #3

Updated by Andy Fiddaman 7 months ago

Check that python3.9 /usr/lib/zfs/pyzfs.py operates,
also import libbe_py under python3.9, and I have also tested that a full pkg update works with python 3.9 including BE creation and activation.

A full gate build with python 3.9 has also been done which exercises validate_pkg and friends.

Actions #4

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 8a647f8fd0cebaabbf80f82d3710a26ef8d7229c

commit  8a647f8fd0cebaabbf80f82d3710a26ef8d7229c
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2020-10-15T13:44:22.000Z

    13217 Allow building with python 3.9
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF