Actions
Bug #13221
closed
mapfile name for unix should be less generic
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
Description
Upstream of Joyent OS-7838:
While addressing OS-7835, I discovered that all of the uts/*/unix Makefiles use the generic MAPFILE name to build the unix module, rather than something more specific. This gets in the way of other machine-specific modules using such a name that makes sense. The variable for the unix mapfile should probably be renamed to UNIX_MAPFILE.
Updated by Jason King over 1 year ago
This change has been in SmartOS for over a year (and thus has been subjected to many builds).
Additionally, after applying the change to illumos-gate, I built and booted an amd64 kernel without issue.
Updated by
Updated by Jason King over 1 year ago
Toomas was also kind enough to build and successfully boot this change on Sparc as well.
Updated by Electric Monk over 1 year ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit 91ab9467e54c18d8133142e5704929a65e13a449
commit 91ab9467e54c18d8133142e5704929a65e13a449
Author: Patrick Mooney <pmooney@pfmooney.com>
Date: 2020-10-16T20:17:17.000Z
13221 mapfile name for unix should be less generic
Reviewed by: Robert Mustacchi <robert.mustacchi@joyent.com>
Reviewed by: John Levon <john.levon@joyent.com>
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Toomas Soome <tsoome@me.com>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions