Actions
Bug #13222
closed
Increase maximum number of fanout CPUs from 128 to 256
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
There is a define which limits the maximum number of fanout CPUs, it is:
#define MRP_NCPUS 128
I think we should change it to
#define MRP_NCPUS NCPU
Related issues
Updated by Paul Winder almost 3 years ago
- Related to Bug #13218: "Stack smashing detected" panic when creating vnic over aggr with 4 mlxcx links added
Updated by Paul Winder almost 3 years ago
Using NCPU won't work - header is included in user land.
We have never hit the limit of 128 fanout CPUs yet anyway, I'll increase to 256 and add an appropriate guard to prevent overflowing any arrays.
It is related to the efforts in #13218
Updated by Paul Winder almost 3 years ago
- Subject changed from Maximum number of fanout CPUs is restricted to 128 to Increase maximum number of fanout CPUs from 128 to 256
Updated by Electric Monk almost 3 years ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
git commit 3714f7be8e09c39a0ea7ce7ef44cb495ce250913
commit 3714f7be8e09c39a0ea7ce7ef44cb495ce250913
Author: Paul Winder <paul@winder.uk.net>
Date: 2020-12-16T14:23:43.000Z
13218 "Stack smashing detected" panic when creating vnic over aggr with 4 mlxcx links
13222 Increase maximum number of fanout CPUs from 128 to 256
Reviewed by: Robert Mustacchi <rm@fingolfin.org>
Reviewed by: Garrett D'Amore <garrett@damore.org>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions