Project

General

Profile

Actions

Bug #13224

closed

loader: edd_device_path_v3 is too small

Added by Toomas Soome 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The EDD v31, see table 13, page 33, does define device path as double
qword, that is, 16 bytes, we have only qword.

Also remove edd_device_path_v4 and edd_params_v4 because those are not used,
and there is no size difference in v3 versus v4.

[1] http://www.t13.org/documents/UploadedDocuments/docs2004/d1572r3-EDD3.pdf

Testing done: build/install/boot

Actions #1

Updated by Electric Monk 7 months ago

  • Gerrit CR set to 977
Actions #2

Updated by Toomas Soome 7 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 4e59aad1e081d538a84310b0d0eec7556a710eb9

commit  4e59aad1e081d538a84310b0d0eec7556a710eb9
Author: Toomas Soome <tsoome@me.com>
Date:   2020-10-16T20:26:39.000Z

    13224 loader: edd_device_path_v3 is too small
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF