Project

General

Profile

Actions

Bug #13229

closed

scadm: this 'if' clause does not guard...

Added by Toomas Soome 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error on sparc:

    common/show.c: In function 'ADM_Process_show_network':
    common/show.c:110:2: error: this 'if' clause does not guard... [-Werror=misleadi
    ng-indentation]
      if (strcmp(netParams->ipMode, "dhcp") == 0)
      ^~
    common/show.c:113:3: note: ...this statement, but the latter is misleadingly ind
    ented as if it were guarded by the 'if'
       (void) printf("%s %s\r\n", gettext("IP Address:"),
       ^
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk 7 months ago

  • Gerrit CR set to 982
Actions #2

Updated by Electric Monk 6 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit e3522c16ecc36b92b1a4b1c7f114205270965e69

commit  e3522c16ecc36b92b1a4b1c7f114205270965e69
Author: Toomas Soome <tsoome@me.com>
Date:   2020-11-10T19:38:25.000Z

    13229 scadm: this 'if' clause does not guard...
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF