Project

General

Profile

Feature #13239

umip, etc. are incorrectly conditioned in cpuid.c

Added by Robert Mustacchi about 1 month ago. Updated 27 days ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While working on #13238, I noiced that UMIP, PKU, and PKE were incorrectly dependent on a couple features related to saving and restoring the FPU through the older fxsave instructions. This changes this to be a bit more general.

#1

Updated by Electric Monk about 1 month ago

  • Gerrit CR set to 1006
#2

Updated by Robert Mustacchi about 1 month ago

I verified this by making sure that we still saw the expected features in ::x86_featureset.

#3

Updated by Electric Monk 27 days ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 5edbd2fec7b63b423df5bd21c4b0f7b775123a40

commit  5edbd2fec7b63b423df5bd21c4b0f7b775123a40
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-11-02T16:22:45.000Z

    13238 vaes, vpclmulqdq should be plumbed through isainfo
    13239 umip, etc. are incorrectly conditioned in cpuid.c
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF