Project

General

Profile

Bug #13261

libdbus-1 deps missing libbsm

Added by Robert Mustacchi 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Today, libdsus-1 is expected to come from the build machine. To account for the fact that we want to make sure we generally refer to its dependencies from the proto area, we have an internal list of library dependencies that are a part of this in lib/Makefile. Looking at a recent dbus-1.so with elfdump, we'll see that it has a DT_NEEDED entry for libbsm.so.1, but this is not listed in the deps line. We should add it.


Related issues

Blocks illumos gate - Feature #13274: enable -fstack-protector-strong by default in user landClosedRobert Mustacchi

Actions
#1

Updated by Robert Mustacchi 4 months ago

  • Blocks Feature #13274: enable -fstack-protector-strong by default in user land added
#2

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 1022
#3

Updated by Robert Mustacchi 4 months ago

I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the build on systems with and without the stack protector work that led to me discovering this.

#4

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 4fcda281302fdcc1753c1f266173e7b59a500c3c

commit  4fcda281302fdcc1753c1f266173e7b59a500c3c
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-11-04T15:32:07.000Z

    13261 libdbus-1 deps missing libbsm
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF