Actions
Bug #13261
closed
libdbus-1 deps missing libbsm
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
Today, libdsus-1 is expected to come from the build machine. To account for the fact that we want to make sure we generally refer to its dependencies from the proto area, we have an internal list of library dependencies that are a part of this in lib/Makefile. Looking at a recent dbus-1.so with elfdump, we'll see that it has a DT_NEEDED entry for libbsm.so.1, but this is not listed in the deps line. We should add it.
Related issues
Updated by Robert Mustacchi over 2 years ago
- Blocks Feature #13274: enable -fstack-protector-strong by default in user land added
Updated by Robert Mustacchi over 2 years ago
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the build on systems with and without the stack protector work that led to me discovering this.
Updated by Electric Monk over 2 years ago
- Status changed from New to Closed
- % Done changed from 90 to 100
git commit 4fcda281302fdcc1753c1f266173e7b59a500c3c
commit 4fcda281302fdcc1753c1f266173e7b59a500c3c
Author: Robert Mustacchi <rm@fingolfin.org>
Date: 2020-11-04T15:32:07.000Z
13261 libdbus-1 deps missing libbsm
Reviewed by: Richard Lowe <richlowe@richlowe.net>
Reviewed by: C Fraire <cfraire@me.com>
Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
Approved by: Gordon Ross <gordon.w.ross@gmail.com>
Actions