Project

General

Profile

Bug #13263

startd needs to search $(ROOT)/usr/lib/fm for deps

Added by Robert Mustacchi 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
smf
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

startd currently links against libfmevent.so which is found in /lib/fm. This library has a dependency itself on libtopo.so.1 which is found in /usr/lib/fm. The run-time part of this is fine because the startd Makefile has a run path for /lib/fm and libfmevent has the appropriate run path to find libtopo. However, at build time, this run-path cannot be relied upon as it would lead to finding the native libtopo and not that in the proto area. To solve this the startd makefile just needs to add an extra -L$(ROOT)/usr/lib/fm.


Related issues

Blocks illumos gate - Feature #13274: enable -fstack-protector-strong by default in user landClosedRobert Mustacchi

Actions
#1

Updated by Robert Mustacchi 4 months ago

  • Blocks Feature #13274: enable -fstack-protector-strong by default in user land added
#2

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 1024
#3

Updated by Robert Mustacchi 4 months ago

I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the build on systems with and without the stack protector work that led to me discovering this.

#4

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 42c24f1c09b6b8d403ee0940c6f1362249a8b738

commit  42c24f1c09b6b8d403ee0940c6f1362249a8b738
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-11-04T15:32:14.000Z

    13263 startd needs to search $(ROOT)/usr/lib/fm for deps
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF