Project

General

Profile

Bug #13264

perl Makefiles place object files after libraries

Added by Robert Mustacchi 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The perl Makefiles in usr/src/cmd/perl are constructed such that all library dependencies are placed before the actual object files. This sometimes works out, but it should really be the other way around. As a bonus, this simplifies the special casing needing in the build rules.


Related issues

Blocks illumos gate - Feature #13274: enable -fstack-protector-strong by default in user landClosedRobert Mustacchi

Actions
#1

Updated by Robert Mustacchi 4 months ago

  • Blocks Feature #13274: enable -fstack-protector-strong by default in user land added
#2

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 1025
#3

Updated by Robert Mustacchi 4 months ago

I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the build on systems with and without the stack protector work that led to me discovering this.

#4

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 9894d69ccc165ef74bf6ccce5a722cdefc922f18

commit  9894d69ccc165ef74bf6ccce5a722cdefc922f18
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-11-04T15:32:16.000Z

    13264 perl Makefiles place object files after libraries
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF