Project

General

Profile

Bug #13266

mdb build tools should use native tools

Added by Robert Mustacchi 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
mdb - modular debugger
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

mdb has a few tools that it uses to try and get access to information, findfp and setdynflag that are meant to be built natively. Right now those are being built against the proto area rather than the native build system, which leads to build woes when they are executed because they can end up with a dependency against the proto area that can't be satisfied by the actual build system. The fix is to just always treat them as native builds.


Related issues

Blocks illumos gate - Feature #13274: enable -fstack-protector-strong by default in user landClosedRobert Mustacchi

Actions
#1

Updated by Robert Mustacchi 4 months ago

  • Blocks Feature #13274: enable -fstack-protector-strong by default in user land added
#2

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 1027
#3

Updated by Robert Mustacchi 4 months ago

I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the build on systems with and without the stack protector work that led to me discovering this.

#4

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 6f9fa98c81a60fc52e8a0a97930ac709e7272727

commit  6f9fa98c81a60fc52e8a0a97930ac709e7272727
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-11-04T15:32:22.000Z

    13266 mdb build tools should use native tools
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF