Project

General

Profile

Actions

Bug #13267

closed

tools libld build picks up normal sgs libs

Added by Robert Mustacchi 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

We build an ld to run on the build host to make it easier to use new features in the build. To do this, we try to reuse the normal Makefiles from cmd/sgs. The libld Makefile.com in cmd/sgs/libld ends up adding search paths to the build directories of various cmd/sgs components. When doing a full build, this ends up being fine because there's nothing there and the tools search paths which come later are fine. However, when doing an incremental build, it will actually find and link against these first, which can be especially problematic if they require features from the proto area that aren't on the build system. The solution to this is to just fix up the library paths in the tools Makefile and make sure we don't pick up anything there.


Related issues

Blocks illumos gate - Feature #13274: enable -fstack-protector-strong by default in user landClosedRobert Mustacchi

Actions
Actions #1

Updated by Robert Mustacchi 6 months ago

  • Blocks Feature #13274: enable -fstack-protector-strong by default in user land added
Actions #2

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 1028
Actions #3

Updated by Electric Monk 6 months ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 90f7985f020eb82d06bd0d75396ff794105f7528

commit  90f7985f020eb82d06bd0d75396ff794105f7528
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-11-04T15:32:25.000Z

    13267 tools libld build picks up normal sgs libs
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF