Actions
Bug #13268
closed
lp native build forgot CFLAGS
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
cmd/lp has a native build where a few different utilities are built. While most of the native flags are correctly set up, the cflags were not correctly set to NATIVE_CFLAGS. If we don't do this, we'll end up picking up cflags that might not be appropriate for the native compiler.
Related issues
Updated by Robert Mustacchi over 2 years ago
- Blocks Feature #13274: enable -fstack-protector-strong by default in user land added
Updated by Robert Mustacchi over 2 years ago
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the build on systems with and without the stack protector work that led to me discovering this.
Updated by Electric Monk over 2 years ago
- Status changed from New to Closed
- % Done changed from 80 to 100
git commit 217f7406cb5a102a47f8ad05f1a14d967486671b
commit 217f7406cb5a102a47f8ad05f1a14d967486671b
Author: Robert Mustacchi <rm@fingolfin.org>
Date: 2020-11-04T15:32:27.000Z
13268 lp native build forgot CFLAGS
Reviewed by: Richard Lowe <richlowe@richlowe.net>
Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
Reviewed by: Toomas Soome <tsoome@me.com>
Approved by: Gordon Ross <gordon.w.ross@gmail.com>
Actions