Project

General

Profile

Bug #13270

cmd/spell native build incomplete

Added by Robert Mustacchi 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The cmd/spell build has a native program and while it make sure to set up CC and CPPFLAGS for the native build, it doesn't do the same for CFLAGS and LDLIBS. This should be fixed to always use the native paths.


Related issues

Blocks illumos gate - Feature #13274: enable -fstack-protector-strong by default in user landClosedRobert Mustacchi

Actions
#1

Updated by Robert Mustacchi 4 months ago

  • Blocks Feature #13274: enable -fstack-protector-strong by default in user land added
#2

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 1031
#3

Updated by Robert Mustacchi 4 months ago

I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the build on systems with and without the stack protector work that led to me discovering this.

#4

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit dd49d7b32f2281b4a30555d0ef9bf80720bbb67f

commit  dd49d7b32f2281b4a30555d0ef9bf80720bbb67f
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-11-04T15:32:32.000Z

    13270 cmd/spell native build incomplete
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF