Project

General

Profile

Actions
Copy link

Bug #13281

closed

bump crypto tests timeout

Added by Robert Mustacchi almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
tests
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1038
External Bug:

Description

Today, the pkcs11 crypto tests are written in such a way that they honor pkcs11.conf, which is a bit unfortunate as it means that folks can end up testing different things at different times and in some cases the tpm module shows up, even without a tpm present and induces a bunch of latency in creating a pkcs11 slot, which these tests do consistently. While not everyone sees this due to local modifications, on a stock onu, the tests will time out on various Intel and AMD systems for these reasons and not becaues the actual CPU time of cryptographic work. As a result, for the time being we should bump the timeout until the tests are made a little more reliable in the face of run-time secenarios.

Actions
Copy link
 #1

Updated by Electric Monk almost 3 years ago

  • Gerrit CR set to 1038
Actions
Copy link
 #2

Updated by Robert Mustacchi almost 3 years ago

I tested this by making sure that the crypto tests now all pass successfully and do not time out.

Actions
Copy link
 #3

Updated by Electric Monk almost 3 years ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 7b34a9a5df26271af0da06974fc361c468cd48d3

commit  7b34a9a5df26271af0da06974fc361c468cd48d3
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-11-10T01:36:54.000Z

    13281 bump crypto tests timeout
    Reviewed by: Jason Lippert <jason@glasspelican.ca>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF