Project

General

Profile

Bug #13285

remove incomplete kmod guidance implementation

Added by Rich Lowe 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The -ztype=kmod support accidentally included a partial implementation of guidance suggesting its use in place of -r -dy, this partial implementation is incomplete and should be removed.

While guidance on the matter would in theory be useful, so little guidance applies to kernel modules (and guidance is not enabled for them) it would be better to remove it, pending a fully correct and used implementation.


Related issues

Related to illumos gate - Bug #13295: ld -zguidance should be aware of different output typesNew

Actions
#1

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 1043
#2

Updated by Rich Lowe 5 months ago

  • Status changed from New to In Progress

tested with a full build, built bge with guidance to check we only get the other erroneous guidance now due to guidance not really being fully aware of the kernel environment.

#3

Updated by Rich Lowe 5 months ago

  • Related to Bug #13295: ld -zguidance should be aware of different output types added
#4

Updated by Electric Monk 5 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit f0b6369dcf843cd097edef20ec38c11b7ae127d6

commit  f0b6369dcf843cd097edef20ec38c11b7ae127d6
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2020-11-16T19:18:41.000Z

    13285 remove incomplete kmod guidance implementation
    Reviewed by: Jason Lippert <jason@glasspelican.ca>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Also available in: Atom PDF