illumos gate

I managed to get some dtrace of smb_vop_ functions and I see some ops among them a setattr some time after the test program has ended.
I'll try to get into details of this ops.

It looks a bit like the close operations happen twice

I did some further dtrace research and was able to track it down to a specific code section, forcing mtime change on close in error here, I think.

https://github.com/illumos/illumos-gate/blob/27f3c5a8194b190aeea38638adf95bd93e61cef1/usr/src/uts/common/fs/smbsrv/smb_ofile.c#L508

The problem is easy to reproduce with np++, open txt file, change sth, safe, change sth again, do not safe, switch window, maybe wait some/several seconds, switch back.

If interested I can share my dtrace stuff.

Ok I disabled the code as Gordon has suggested, seems to solve the problem for now.
Would be good if someone can check in detail, if this code is more than really needed to meet the specs or if the f_written bit was set when it should not.
Additionally I'd like to mention, that I haven't found the initializer for this yet, maybe it is as simple as this.

Here the diff of the provisional fix:

diff --git a/usr/src/uts/common/fs/smbsrv/smb_ofile.c b/usr/src/uts/common/fs/smbsrv/smb_ofile.c
index d5388037c3..6f9e839e24 100644
--- a/usr/src/uts/common/fs/smbsrv/smb_ofile.c
+++ b/usr/src/uts/common/fs/smbsrv/smb_ofile.c
@@ -505,12 +505,14 @@ smb_ofile_close(smb_ofile_t *of, int32_t mtime_sec)
                 * during the close.  Windows expects this.
                 * [ MS-FSA 2.1.5.4 "Update Timestamps" ]
                 */
+#if 0
                if (of->f_written &&
                    (pa->sa_mask & SMB_AT_MTIME) == 0) {
                        pa->sa_mask |= SMB_AT_MTIME;
                        gethrestime(&now);
                        pa->sa_vattr.va_mtime = now;
                }
+#endif

                if (of->f_flags & SMB_OFLAGS_SET_DELETE_ON_CLOSE) {
                        /* We delete using the on-disk name. */

Testing:
1: submitter verification
2: Windows protocol test suite BVT (no change)