Project

General

Profile

Actions
Copy link

Bug #13302

closed

pthread_attr_get_np.3c erroneously refers to pthread_getattr_np

Added by Peter Tribble over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Tribble
Category:
manpage - manual pages
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1054

Description

The notes for #6501 indicate that only pthread_attr_get_np() was implemented, and pthread_getattr_np() wasn't.

However, as noted during review of #13289, the pthread_attr_get_np.3c man page contains an errant reference to pthread_getattr_np() that should be removed.

Actions
Copy link
 #1

Updated by Peter Tribble over 1 year ago

It's also the case that the code comment

http://src.illumos.org/source/xref/illumos-gate/usr/src/lib/libc/port/threads/pthread.c#135

uses the wrong form of the name.

And the comments on this

http://src.illumos.org/source/xref/illumos-gate/usr/src/lib/libc/port/threads/pthr_attr.c#530

could do with tidying - "it's", "subtley", "called on in".

Actions
Copy link
 #2

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1054
Actions
Copy link
 #3

Updated by Peter Tribble over 1 year ago

Testing: checked the modified man page using man(1), and eyeballed the
modified comments.

Actions
Copy link
 #4

Updated by Electric Monk over 1 year ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 25befe07d3c1488cbbdecdb765cd0558e12cc364

commit  25befe07d3c1488cbbdecdb765cd0558e12cc364
Author: Peter Tribble <peter.tribble@gmail.com>
Date:   2020-11-14T18:07:33.000Z

    13302 pthread_attr_get_np.3c erroneously refers to pthread_getattr_np
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF