Project

General

Profile

Actions

Bug #13319

closed

Typos in some LDSTACKPROTECT macros

Added by Robert Mustacchi 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

With the work in #13274 to enable the tack protector in the build, an effort was made to mimic the conditions that were set up back in #11866 based on work that was initially done by Alex Wilson. We added a few macros for the LD pieces; however, there are a few typos in that. Because these were modes that we don't currently use in userland, this was not found in the build itself and does not directly impact the work in #13274.

Actions #1

Updated by Electric Monk 10 months ago

  • Gerrit CR set to 1067
Actions #2

Updated by Robert Mustacchi 10 months ago

To test this, I ran a wsdiff and verified that there was nothing surprising there (e.g. acpi and hlist).

Actions #3

Updated by Electric Monk 10 months ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit a39905c1c6671c3f44d52e31393ee7cdda7b4f12

commit  a39905c1c6671c3f44d52e31393ee7cdda7b4f12
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-11-23T16:03:08.000Z

    13319 Typos in some LDSTACKPROTECT macros
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF