Project

General

Profile

Bug #13323

CTF forward test needs adjusting after 13278

Added by Andy Fiddaman 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tests
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The CTF forward declaration tests says:

 * In test-forward.c barp is declared as a union, not a struct. However, today
 * the CTF tooling does not contain enough information to know whether a forward
 * declaration was for a struct or a union, only that it was a forward.
 * Therefore, the type printing information assumes at the moment that the type
 * is a struct. In a future revision of the CTF type data, we should encode this
 * information in the equivalent of ctt_info so we can properly distinguish
 * between these.

13278 fixed this and the type of a forward declaration is now known. The test needs adjusting.

The test now fails with:

check-forward-32: failed to lookup type struct bar * for symbol barp
check-forward-32: failed to lookup type struct bar *
check-forward-32: member data has bad type, found union bar *, expected struct bar *
TEST FAILED: check for /opt/util-tests/tests/ctf/test-forward.c, /opt/util-tests/tests/ctf/check-forward-32, failed

Related issues

Related to illumos gate - Bug #13278: CTF assertion failed cmp->cm_tmap[id].cmt_map == suidClosedAndy Fiddaman

Actions
#1

Updated by Andy Fiddaman 5 months ago

  • Related to Bug #13278: CTF assertion failed cmp->cm_tmap[id].cmt_map == suid added
#2

Updated by Andy Fiddaman 5 months ago

  • Description updated (diff)
#3

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 1069
#4

Updated by Andy Fiddaman 5 months ago

I tested running the original test suite under an old OmniOS release and the updated one on the latest bloody version. In both cases there were the same two test failures and the two check-forward tests passed.

#5

Updated by Electric Monk 5 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 986529380f11a23c3c6de33e5cea6611d4abe648

commit  986529380f11a23c3c6de33e5cea6611d4abe648
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2020-11-20T22:03:19.000Z

    13323 CTF forward test needs adjusting after 13278
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF