Project

General

Profile

Actions
Copy link

Bug #13334

closed

Recognize X710 10GBaseT*L Family

Added by Dan McDonald almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1178
External Bug:

Description

An OmniOS user reports that PCI ID 8086,15ff does not have i40e attach. A quick source dive confirms we do not support this device. It's a 10GBaseT, for which we HAVE support for other versions (e.g. 8086,1586).

Actions
Copy link
 #1

Updated by Robert Mustacchi over 2 years ago

  • Subject changed from Recognize X710 10GBaseT device 8086,15ff to Recognize X710 10GBaseT*L Family
  • Assignee set to Robert Mustacchi
Actions
Copy link
 #2

Updated by Robert Mustacchi over 2 years ago

There was a set of several different devices that Intel added which have support for 100BASE-T, 1, 2.5, 5, and 10GBASE-T. It'd be good to update the common code to get support for these newer devices.

Actions
Copy link
 #3

Updated by Electric Monk over 2 years ago

  • Gerrit CR set to 1178
Actions
Copy link
 #4

Updated by Robert Mustacchi over 2 years ago

This was tested on the following parts by members of the broader community (Thanks Dan, Ryan, and Jorge):

  • X722 for 10GBASE-T (8086,37d2)
  • X710 for 10GbE SFP+ (8086,1572)

The testing covered use of VNICs, VLANs, promiscuous mode, LSO, bhyve, etc. In particular, Ryan was kind enough to use the net-tests against this:

rpz@thunderhead:~/rpz-misc/illumos/net-tests$ pfexec ./mac-tests i40e2 i40e3
PASS [test_mac_vnic_rx<i40e3>]
PASS [test_mac_vlan_rx<i40e3>]
PASS [test_mac_sw_to_hw<i40e3>]
PASS [test_mac_promisc<i40e3>]
PASS [test_mac_promisc_vlan<i40e3>]
PASS [test_mac_all_groups<i40e3>]
PASS [test_mac_vlan_all_groups<i40e3>]
PASS [test_mac_steal_group<i40e3>]
PASS [test_mac_vlan_steal_group<i40e3>]
PASS [test_mac_groups_vlan_shared_addr<i40e3>]
PASS [test_mac_vlan_shared_addr<i40e3>]
PASS [test_mac_two_vlans_on_default<i40e3>]

rpz@thunderhead:~/rpz-misc/illumos/net-tests$ pfexec ./lso-tests i40e2 i40e3
PASS [test_lso_ip4_primary<i40e2>]
PASS [test_lso_ip4_vnic<i40e2>]
PASS [test_lso_ip4_mac_loopback<i40e2>]

% The following tests will elide the LSO check until the   %
% mac sw LSO is updated to handle IPv6 -- for now these    %
& tests only verify that traffic is sent, not LSO.         %
PASS [test_lso_ip6_primary<i40e2>]
PASS [test_lso_ip6_vnic<i40e2>]
PASS [test_lso_ip6_mac_loopback<i40e2>]
Actions
Copy link
 #5

Updated by Electric Monk over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit df36e06d12cbf655ddf22339ef8c39fa2b83ebf8

commit  df36e06d12cbf655ddf22339ef8c39fa2b83ebf8
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2021-01-29T23:31:31.000Z

    13334 Recognize X710 10GBaseT*L Family
    Reviewed by: Ryan Zezeski <ryan@oxide.computer>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions
Copy link

Also available in: Atom PDF