Project

General

Profile

Bug #13340

zoneadmd shouldn't rely on autofs

Added by Jerry Jelinek 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zones
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

During zone filesystem unmounting, it is possible for zoneadmd to call into autofs_cleanup
which directly makes a syscall into the the kernel's autofs module. If a distro chooses not
to deliver autofs, then this will fail and short-circuit zoneadmd's filesystem cleanup. We could
improve zoneadmd to handling a missing autofs module more gracefully.

#1

Updated by Jerry Jelinek 5 months ago

  • % Done changed from 0 to 90
#2

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 1081
#3

Updated by Jerry Jelinek 5 months ago

To test this, I ran it on our Racktop platform and triggered the error path during zone shutdown to reproduce the aborted cleanup. After the fix, I retested and the loop now reports the problematic unmount correctly. The zone also continues to shutdown normally when there is no problematic unmount to trigger the error path.

#4

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 8af575c0afc1d79bd23c3e1a78a546c9963e5083

commit  8af575c0afc1d79bd23c3e1a78a546c9963e5083
Author: Jerry Jelinek <gjelinek@gmail.com>
Date:   2020-12-02T18:13:55.000Z

    13340 zoneadmd shouldn't rely on autofs
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF