Project

General

Profile

Actions

Bug #13345

closed

loader: xdr_array is missing count

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The integer arrays are encoded in nvlist as counted array <count, i0, i1...>, loader xdr_array() is missing the count. This will affect the pool import when there are hole devices in pool.

Also fix the new data add and print functions.

Testing done:
can now read pool with hole_array property (DATA_TYPE_UINT64_ARRAY).
nvlist_print() (when used) does output nvlist with array of integers
nvstore rpool -t DATA_TYPE_UINT64_ARRAY test 1234 does create property 'test' with value 1234 (confirmed with eeprom -bp).


Related issues

Related to illumos gate - Bug #13353: loader: 13345 did miss byte and nvlist arrayClosedToomas Soome

Actions
Actions #1

Updated by Toomas Soome over 1 year ago

  • Description updated (diff)
Actions #2

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 0b14c19974d0288384932500f606afeadc2d6009

commit  0b14c19974d0288384932500f606afeadc2d6009
Author: Toomas Soome <tsoome@me.com>
Date:   2020-12-07T07:37:37.000Z

    13345 loader: xdr_array is missing count
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions #3

Updated by Toomas Soome over 1 year ago

  • Related to Bug #13353: loader: 13345 did miss byte and nvlist array added
Actions #4

Updated by Patrick Mooney over 1 year ago

I tested the now-merged wad on my lab machine which had a pool affected by this. With the fix in place, loader is able to function properly once again.

Actions

Also available in: Atom PDF