Project

General

Profile

Feature #13348

ctftest should skip known failures with clang

Added by Robert Mustacchi 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
tests
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

There are some known bugs in clang's dwarf generation -- https://bugs.llvm.org/show_bug.cgi?id=44601. As such it'd help if the CTF test suite actively went and knew about this and said that it was skipping it due to a known failure allowing the tests to otherwise pass.


Related issues

Blocks illumos gate - Feature #13366: Add CTF tests for new featuresIn ProgressAndy Fiddaman

Actions
#1

Updated by Robert Mustacchi 4 months ago

I tested this by running the CTF test suite against a number of different compilers with both -gdwarf-2 and -gdwarf-4 (when supported). The compilers were:

  • gcc 4.4.4
  • gcc 7.4.0
  • gcc 7.5.0
  • gcc 8.3.0
  • gcc 9.3.0
  • gcc 10.2.0
  • clang 8.0.1
  • clang 9.0.1
  • clang 10.0.1
  • clang 11.0.0

I verified that in all of the clang cases we skipped the tests that were known failures and that this was printed out.

#2

Updated by Andy Fiddaman 4 months ago

#3

Updated by Andy Fiddaman 4 months ago

#4

Updated by Andy Fiddaman 4 months ago

#5

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 3cec98229bf077e97e442c942c2bd8768e277449

commit  3cec98229bf077e97e442c942c2bd8768e277449
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-12-15T14:56:00.000Z

    12229 fix ctf test check-qualifiers for clang
    12230 clang optimizer defeats ctf test suite
    12231 ctf tests should not pass -h directly to clang
    12232 fix clang compiler warnings in the ctf test suite
    13348 ctftest should skip known failures with clang
    13350 some ctf tests still rely on default compiler arch
    13349 ctf tests should specify -fcommon when needed
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF