Project

General

Profile

Actions

Feature #13349

closed

ctf tests should specify -fcommon when needed

Added by Robert Mustacchi 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Category:
tests
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

There are a few tests that are explicitly designed to test cases around having duplicate symbols with different types in different object files. This requires that the compiler pass -fcommon, which was the default until the GCC 10 era of compilers. As a result, rather than assuming this will be the compiler's default we should just pass that flag when required.


Related issues

Blocks illumos gate - Feature #13366: Add CTF tests for new featuresIn ProgressAndy Fiddaman

Actions
Actions #1

Updated by Robert Mustacchi 10 months ago

I tested this by running the CTF test suite against a number of different compilers with both -gdwarf-2 and -gdwarf-4 (when supported). The compilers were:

  • gcc 4.4.4
  • gcc 7.4.0
  • gcc 7.5.0
  • gcc 8.3.0
  • gcc 9.3.0
  • gcc 10.2.0
  • clang 8.0.1
  • clang 9.0.1
  • clang 10.0.1
  • clang 11.0.0
Actions #2

Updated by Andy Fiddaman 9 months ago

Actions #3

Updated by Andy Fiddaman 9 months ago

Actions #4

Updated by Andy Fiddaman 9 months ago

Actions #5

Updated by Electric Monk 9 months ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 3cec98229bf077e97e442c942c2bd8768e277449

commit  3cec98229bf077e97e442c942c2bd8768e277449
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-12-15T14:56:00.000Z

    12229 fix ctf test check-qualifiers for clang
    12230 clang optimizer defeats ctf test suite
    12231 ctf tests should not pass -h directly to clang
    12232 fix clang compiler warnings in the ctf test suite
    13348 ctftest should skip known failures with clang
    13350 some ctf tests still rely on default compiler arch
    13349 ctf tests should specify -fcommon when needed
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF