Project

General

Profile

Actions
Copy link

Bug #13351

closed

loader: vbe_find_mode_xydm() is using wrong safety and iteration is buggy

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1093

Description

We are using iterate count max mode # (0x1ff) - min vbe mode (0x100) + 1 = 0x100.

If depth is unspecified, we walk down from 32 to 8, but fail to restart from initial farptr and zero safety counter for new depth.

Testing done: tested on system which only does provide 8-bit depth and failed to pick the mode before.

Actions
Copy link
 #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1093
Actions
Copy link
 #2

Updated by Toomas Soome over 1 year ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit d20422bd742384b77102bb3bd09e0dc4b7372e50

commit  d20422bd742384b77102bb3bd09e0dc4b7372e50
Author: Toomas Soome <tsoome@me.com>
Date:   2020-12-29T19:52:58.000Z

    13351 loader: vbe_find_mode_xydm() is using wrong safety and iteration is buggy
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF