Actions
Feature #13352
closed
disable mdns date and time in version string
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
The dns-sd binary generally encodes its build time in a version string. This leads to spurious wsdiff noise and makes it harder to create a reproducible build. The source code has a macro that we can define to remove this from the string: MDNS_VERSIONSTR_NODTS. We should define this macro when building. This causes the version string to no longer include the date and time.
Updated by Robert Mustacchi over 2 years ago
I tested this in two ways. The first was by running the updated dns-sd binary to make sure we got the updated version information. The second was by running wsdiff across two builds of the same workspace and verifying that they no longer had any wsdiff noise.
Updated by Electric Monk over 2 years ago
- Status changed from New to Closed
- % Done changed from 80 to 100
git commit f73e1ebf60792a8bdb2d559097c3131b68c09318
commit f73e1ebf60792a8bdb2d559097c3131b68c09318
Author: Robert Mustacchi <rm@fingolfin.org>
Date: 2021-01-12T23:26:25.000Z
13352 disable mdns date and time in version string
Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
Reviewed by: Andy Fiddaman <andy@omnios.org>
Reviewed by: Paul Winder <paul@winder.uk.net>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions