Project

General

Profile

Actions

Feature #13355

closed

remove topo module warning gags

Added by Robert Mustacchi 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Right now there are some warning gags in the topo modules around uninitialized variables and parenthesis. We should remove these as they can potentially mask some real issues. We should clean those up as they can hide things like https://github.com/joyent/illumos-joyent/issues/343.

Actions #1

Updated by Electric Monk 9 months ago

  • Gerrit CR set to 1098
Actions #2

Updated by Robert Mustacchi 9 months ago

I tested this by doing before and after runs of `/usr/lib/fm/fmd/fmtop -V` on hardware systems I had as well as some that Dan had.

Actions #3

Updated by Electric Monk 9 months ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 58d4b16fe601073f2408de78e3db7e9bfa9abfd2

commit  58d4b16fe601073f2408de78e3db7e9bfa9abfd2
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-12-25T00:03:42.000Z

    13355 remove topo module warning gags
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.dev>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF