Project

General

Profile

Actions

Feature #13373

closed

Import upstream improvements to bhyve VNC server

Added by Andy Fiddaman 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bhyve
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

A number of improvements have recently been made to bhyve's VNC support in FreeBSD including support for the native MacOS screen sharing client.
We should pull those into illumos.

https://reviews.freebsd.org/rS368747

Fix issues with various VNC clients.

* support VNC version 3.3 (macos "Screen Sharing" builtin client)
* wait until client has requested an update prior to sending framebuffer data
* don't send an update if no framebuffer updates detected
* increase framebuffer poll frequency to 30Hz, and double that when kbd/mouse input detected
* zero uninitialized array elements in rfb_send_server_init_msg()
* fix overly large allocation in rfb_init()
* use atomics for flags shared between input and output threads
* use #defines for constants

Related issues

Related to illumos gate - Feature #13379: bhyve upstream sync 2020 DecClosedAndy Fiddaman

Actions
Actions #1

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 1107
Actions #2

Updated by Andy Fiddaman 5 months ago

Actions #3

Updated by Andy Fiddaman 4 months ago

I've tested this on omnios with a variety of different guests, concentrating mostly on Windows 10 for the GUI elements.

Jorge Schrauwen has kindly done additional tests by building a custom SmartOS image with these changes:

Tested the 3rd patch with:

iOS Screens
tightVNC on macOS
screensharing on macKS
For the latest version I only had time to retest the screens and tightvnc.

All work now and tighvnc is a lot smoother and more responsive.

Actions #4

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit dc8050e8896b9c2ed33a0bbe1913bfbf05521997

commit  dc8050e8896b9c2ed33a0bbe1913bfbf05521997
Author: Marko Kiiskila <marko@apache.org>
Date:   2021-01-14T09:35:38.000Z

    13373 Import upstream improvements to bhyve VNC server
    Portions contributed by: Henrik Gulbrandsen <henrik@gulbra.net>
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Reviewed by: Jorge Schrauwen <sjorge@blackdot.be>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions #5

Updated by Andy Fiddaman 3 months ago

Actions #6

Updated by Andy Fiddaman 3 months ago

Actions

Also available in: Atom PDF