Import upstream improvements to bhyve VNC server
A number of improvements have recently been made to bhyve's VNC support in FreeBSD including support for the native MacOS screen sharing client.
We should pull those into illumos.
Fix issues with various VNC clients. * support VNC version 3.3 (macos "Screen Sharing" builtin client) * wait until client has requested an update prior to sending framebuffer data * don't send an update if no framebuffer updates detected * increase framebuffer poll frequency to 30Hz, and double that when kbd/mouse input detected * zero uninitialized array elements in rfb_send_server_init_msg() * fix overly large allocation in rfb_init() * use atomics for flags shared between input and output threads * use #defines for constants
Updated by Andy Fiddaman 4 months ago
I've tested this on omnios with a variety of different guests, concentrating mostly on Windows 10 for the GUI elements.
Jorge Schrauwen has kindly done additional tests by building a custom SmartOS image with these changes:
Tested the 3rd patch with:
tightVNC on macOS
screensharing on macKS
For the latest version I only had time to retest the screens and tightvnc.
All work now and tighvnc is a lot smoother and more responsive.
Updated by Electric Monk 4 months ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
commit dc8050e8896b9c2ed33a0bbe1913bfbf05521997 Author: Marko Kiiskila <email@example.com> Date: 2021-01-14T09:35:38.000Z 13373 Import upstream improvements to bhyve VNC server Portions contributed by: Henrik Gulbrandsen <firstname.lastname@example.org> Reviewed by: Patrick Mooney <email@example.com> Reviewed by: Jorge Schrauwen <firstname.lastname@example.org> Approved by: Gordon Ross <email@example.com>