Project

General

Profile

Feature #13390

clean up libdlpi warning gags

Added by Robert Mustacchi 2 months ago. Updated 28 days ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

We should remove the warning gags that exist in the libdlpi Makefiles.

#1

Updated by Electric Monk 2 months ago

  • Gerrit CR set to 1114
#2

Updated by Robert Mustacchi 29 days ago

Because this primarily touched the i_dlpi_strgetmsg() function, I used dlsend and dlrecv to test this, the latter of which goes through that code path on every tick. I saw the regular one second pings come across.

#3

Updated by Electric Monk 28 days ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 6d177d7a4a2c4b126a6f5ecc7a226e1dcac383ed

commit  6d177d7a4a2c4b126a6f5ecc7a226e1dcac383ed
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2021-02-04T14:39:17.000Z

    13390 clean up libdlpi warning gags
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF