Project

General

Profile

Actions

Bug #13391

closed

fm: build errors with gcc 7 on SPARC

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Building with gcc 7 did reveal few issues:

    etm.c: In function 'etm_async_event_handler':
    etm.c:3199:27: error: comparison between pointer and zero character constant [-W
    error=pointer-compare]
          if (iosvc->ldom_name != '\0')
                               ^~
    etm.c:3199:10: note: did you mean to dereference the pointer?
          if (iosvc->ldom_name != '\0')
              ^
    cc1: all warnings being treated as errors
    *** Error code 1
    dmake: Warning: Command failed for target `etm.o'
    Current working directory /code/illumos-gate/usr/src/cmd/fm/modules/sun4v/etm

    cmd_Lxcacheerr.c: In function 'gen_data_for_ecc':
    cmd_Lxcacheerr.c:480:11: error: variable 'tag_ecc' set but not used [-Werror=unu
    sed-but-set-variable]
      uint16_t tag_ecc[PN_CACHE_NWAYS];
               ^~~~~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot.

Actions #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1115
Actions #2

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 5e96da73c99d9d17ff5a58b793fff2ab6dcadf25

commit  5e96da73c99d9d17ff5a58b793fff2ab6dcadf25
Author: Toomas Soome <tsoome@me.com>
Date:   2020-12-29T17:01:35.000Z

    13391 fm: build errors with gcc 7 on SPARC
    Reviewed by: Yuri Pankov <yuripv@yuripv.dev>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF