Actions
Bug #13399
closed
zfs: error: implicit conversion from 'boolean_t' to 'ds_hold_flags_t'
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
Description
Build error with gcc 10:
../../common/fs/zfs/dmu_objset.c: In function 'dmu_objset_refresh_ownership':
../../common/fs/zfs/dmu_objset.c:857:25: error: implicit conversion from 'boolean_t' to 'ds_hold_flags_t' {aka 'enum ds_hold_flags'} [-Werror=enum-conversion]
857 | dsl_dataset_disown(ds, decrypt, tag);
| ^~~~~~~
cc1: all warnings being treated as errors
ds_hold_flags_t is with single value and can not hold boolean. OpenZFS update https://github.com/openzfs/zfs/pull/11406.
Testing done: zfs-tests from OpenZFS workflow + illumos build/install/boot.
Related issues
Updated by Toomas Soome over 1 year ago
- Related to Bug #13400: zfs-tests: implicit conversion from 'enum dmu_objset_type' to 'enum lzc_dataset_type' added
Updated by Electric Monk over 1 year ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit ef96fc31fc4f4306719704352d5c3e33573c039f
commit ef96fc31fc4f4306719704352d5c3e33573c039f
Author: Toomas Soome <tsoome@me.com>
Date: 2020-12-31T16:15:24.000Z
13399 zfs: error: implicit conversion from 'boolean_t' to 'ds_hold_flags_t'
Reviewed by: Andy Fiddaman <andy@omnios.org>
Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
Approved by: Robert Mustacchi <rm@fingolfin.org>
Actions