Project

General

Profile

Actions

Bug #13400

closed

zfs-tests: implicit conversion from 'enum dmu_objset_type' to 'enum lzc_dataset_type'

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error with gcc 10:

    libzfs_input_check.c: In function 'zfs_ioc_input_tests':
    libzfs_input_check.c:754:28: error: implicit conversion from 'enum dmu_objset_type' to 'enum lzc_dataset_type' [-Werror=enum-conversion]
      754 |  err = lzc_create(dataset, DMU_OST_ZFS, NULL, NULL, 0);
          |                            ^~~~~~~~~~~
    cc1: all warnings being treated as errors

use proper constant. OpenZFS update: https://github.com/openzfs/zfs/pull/11406

Testing done: zfs-tests from OpenZFS workflow, illumos build/install/boot


Related issues

Related to illumos gate - Bug #13399: zfs: error: implicit conversion from 'boolean_t' to 'ds_hold_flags_t'ClosedToomas Soome

Actions
Actions #1

Updated by Toomas Soome over 1 year ago

  • Related to Bug #13399: zfs: error: implicit conversion from 'boolean_t' to 'ds_hold_flags_t' added
Actions #2

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1124
Actions #3

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 9f76c6ed5b6ee0cc0bf631daca15ac3dc5fc70c4

commit  9f76c6ed5b6ee0cc0bf631daca15ac3dc5fc70c4
Author: Toomas Soome <tsoome@me.com>
Date:   2020-12-31T16:15:33.000Z

    13400 zfs-tests: implicit conversion from 'enum dmu_objset_type' to 'enum lzc_dataset_type'
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF