Actions
Feature #13407
closedreduce smatch gags in t4nex
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
Right now all of SMATCH is turned off for the t4nex
driver. We should reduce this. Right now I've left too in place, one of which is about unchecked function returns, which is mostly being done to deal with the general code that Chelsio shares. The second is about snprintf overflows. In practice the cases are OK due to how the versions work, but longer term we can remove that by moving those version strings into the UFM logic.
Updated by Robert Mustacchi over 2 years ago
Updated by Electric Monk over 2 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit 89f249c9183aad7ca607490285fba9fc6cfa2cd0
commit 89f249c9183aad7ca607490285fba9fc6cfa2cd0 Author: Robert Mustacchi <rm@fingolfin.org> Date: 2021-02-15T17:31:29.000Z 13407 reduce smatch gags in t4nex Reviewed by: Gergő Mihály Doma <domag02@gmail.com> Reviewed by: Patrick Mooney <pmooney@pfmooney.com> Reviewed by: Andy Fiddaman <andy@omnios.org> Reviewed by: Richard Lowe <richlowe@richlowe.net> Approved by: Gordon Ross <gordon.w.ross@gmail.com>
Actions