Project

General

Profile

Actions

Bug #13415

closed

psvcpolicy: variable 'curr_state' set but not used

Added by Toomas Soome 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error on SPARC:

    psvcpolicy.c: In function 'psvc_check_disk_fault_policy_0':
    psvcpolicy.c:1852:8: error: variable 'curr_state' set but not used [-Werror=unused-but-set-variable]
      char  curr_state[32], prev_state[32], led_state[32];
            ^~~~~~~~~~
    cc1: all warnings being treated as errors
    *** Error code 1
    dmake: Fatal error: Command failed for target `pics/psvcpolicy.o'
    Current working directory /code/illumos-gate/usr/src/cmd/picl/plugins/sun4u/daktari/psvcpolicy

Testing done: build, I have no sun4u to test with.

Actions #1

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 1136
Actions #2

Updated by Toomas Soome 4 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 338c2f033035af5b17f61d9df825917015c95a35

commit  338c2f033035af5b17f61d9df825917015c95a35
Author: Toomas Soome <tsoome@me.com>
Date:   2021-01-12T19:11:32.000Z

    13415 psvcpolicy: variable 'curr_state' set but not used
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF