Project

General

Profile

Actions

Bug #13441

closed

SMB: Creating named streams on existing files is not quite right

Added by Matt Barden 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cifs - CIFS server and client
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

In MS-FSA, 'file lookup' effectively has the following branches:

1. If the file doesn't exist, create the file and the stream
2. If the file exists, and the stream exists, perform access and sharing checks
3. If the file exists, but the stream doesn't exist, perform access checks, then create the stream.

Currently, 1 and 3 are collapsed into a single branch: If the file exists, but the stream doesn't, that's treated as if the file didn't exist.


Files

stream-test.sh (2.85 KB) stream-test.sh Run tests from client Matt Barden, 2021-01-30 12:22 AM
stream-setup.sh (1013 Bytes) stream-setup.sh Setup tests on server share Matt Barden, 2021-01-30 12:22 AM
Actions #1

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 1160
Actions #2

Updated by Matt Barden 5 months ago

Testing Notes:

Run streams-setup.sh in a directory on a share on the server under test.
Mount the share from an illumos-based client, cd into streams-test-dir, then run streams-test.sh .

Actions #3

Updated by Electric Monk 5 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Closed

git commit 0a73e6f973645e207d33a7012fed997991b4e531

commit  0a73e6f973645e207d33a7012fed997991b4e531
Author: Matt Barden <matt.barden@nexenta.com>
Date:   2021-01-30T19:02:54.000Z

    13441 SMB: Creating named streams on existing files is not quite right
    Reviewed by: Evan Layton <elayton@tintri.com>
    Reviewed by: Gordon Ross <gordon.ross@tintri.com>
    Reviewed by: Roman Strashkin <rstrashkin@tintri.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF