Project

General

Profile

Actions

Feature #13450

closed

Support bhyve passwords for VNC

Added by Andy Fiddaman 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bhyve
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The code is all there and ready (and enabled in SmartOS and OmniOS) but not in gate.

Actions #1

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 1166
Actions #2

Updated by Andy Fiddaman 4 months ago

This change is already present in SmartOS and OmniOS.
Additionally, Jorge Schrauwen kindly applied the patch on top of SmartOS and re-tested, to double check there was no impact, and confirmed that it worked as expected.

Actions #3

Updated by Andy Fiddaman 4 months ago

I have ONUd to this patch and set up an OmniOS bhyve zone with and without a password set on the VNC server.

That is, once with -s 30:0,fbuf,vga=off,unix=/tmp/vm.vnc
and once with -s 30:0,fbuf,vga=off,unix=/tmp/vm.vnc,password=plod123

In the first case, I was able to connect to the VNC session without a password using Jolly's Fast VNC and the MacOS screen sharing client.
In the second, I was prompted for a password. An incorrect password was not accepted, the correct one was.

Actions #4

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 266244706342306580e11c81c21a1a5f3dbfc513

commit  266244706342306580e11c81c21a1a5f3dbfc513
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2021-01-17T00:32:28.000Z

    13450 Support bhyve passwords for VNC
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Mike Zeller <mike.zeller@joyent.com>
    Reviewed by: Jorge Schrauwen <sjorge@blackdot.be>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF