Project

General

Profile

Actions
Copy link

Bug #13456

closed

remove umem check_rtime exception

Added by Robert Mustacchi over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1172
External Bug:

Description

When per-thread caching umem was integrated in #4489, there was an exception added to the check_rtime exception list due to some shenanigans in how it was setting up the code. This was cleaned up in #10936. However, the resulting gag in check_rtime was not. We can and should safely remove it.

Actions
Copy link
 #1

Updated by Electric Monk over 2 years ago

  • Gerrit CR set to 1172
Actions
Copy link
 #2

Updated by Robert Mustacchi over 2 years ago

This was tested entirely through doing both debug and non-debug builds, verifying that check_rtime ran, and that there were no issues reported.

Actions
Copy link
 #3

Updated by Electric Monk over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 4efb20e81cede837b887da28bb6284155a828dab

commit  4efb20e81cede837b887da28bb6284155a828dab
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2021-01-22T16:19:03.000Z

    13456 remove umem check_rtime exception
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions
Copy link

Also available in: Atom PDF