Project

General

Profile

Actions

Bug #13480

closed

wsdiff didn't use to care about directory naming

Added by Rich Lowe over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

for wsdiff, I used to habitually copy the root_* I wanted itself to preserve it, rather than copying proto/ (which probably contained the other debug/non-debug root too, because of multi-proto). This stopped working with ctfdiffs, because we care about the root_ name when locating genunix. It'd be nice if this wasn't the case.

Perhaps we can sniff for a directory that looks like a root, but isn't /?

Actions #1

Updated by Andy Fiddaman over 1 year ago

  • Status changed from New to In Progress
  • Assignee set to Andy Fiddaman
Actions #2

Updated by Andy Fiddaman over 1 year ago

  • Subject changed from wsdiff didn't used to care about directory naming to wsdiff didn't use to care about directory naming
Actions #3

Updated by Andy Fiddaman over 1 year ago

  • Gerrit CR set to 1202
Actions #4

Updated by Andy Fiddaman over 1 year ago

I tested this by running wsdiff between a non-debug and debug proto, and subdirectories thereof, checking that it could properly find the genunix file for ctfdiff and that the output showed just the relative file name for each difference found (i.e. it was properly stripping the path to the proto area).

I then re-tested after moving one of the proto directories to /tmp/testroot to confirm that the output was unchanged.

The output with wsdiff from before and after this change is the same

Actions #5

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit a32b2b2a1fc68ee509dbff96287ca2c319495b53

commit  a32b2b2a1fc68ee509dbff96287ca2c319495b53
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2021-02-08T15:35:00.000Z

    13480 wsdiff didn't use to care about directory naming
    Reviewed by: Rich Lowe <richlowe@richlowe.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF