Bug #13480
closed
wsdiff didn't use to care about directory naming
100%
Description
for wsdiff, I used to habitually copy the root_* I wanted itself to preserve it, rather than copying proto/ (which probably contained the other debug/non-debug root too, because of multi-proto). This stopped working with ctfdiffs, because we care about the root_ name when locating genunix. It'd be nice if this wasn't the case.
Perhaps we can sniff for a directory that looks like a root, but isn't /?
Updated by Andy Fiddaman over 2 years ago
- Status changed from New to In Progress
- Assignee set to Andy Fiddaman
Updated by Andy Fiddaman over 2 years ago
- Subject changed from wsdiff didn't used to care about directory naming to wsdiff didn't use to care about directory naming
Updated by Andy Fiddaman over 2 years ago
I tested this by running wsdiff between a non-debug and debug proto, and subdirectories thereof, checking that it could properly find the genunix file for ctfdiff and that the output showed just the relative file name for each difference found (i.e. it was properly stripping the path to the proto area).
I then re-tested after moving one of the proto directories to /tmp/testroot to confirm that the output was unchanged.
The output with wsdiff from before and after this change is the same
Updated by Electric Monk over 2 years ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
git commit a32b2b2a1fc68ee509dbff96287ca2c319495b53
commit a32b2b2a1fc68ee509dbff96287ca2c319495b53
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date: 2021-02-08T15:35:00.000Z
13480 wsdiff didn't use to care about directory naming
Reviewed by: Rich Lowe <richlowe@richlowe.net>
Approved by: Dan McDonald <danmcd@joyent.com>