Project

General

Profile

Actions

Bug #13486

closed

cmd/ast should use fewer FRC dependencies

Added by Andy Fiddaman 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Header file generation rules within usr/src/cmd/ast use forced targets in too many places, resulting in the components being rebuilt on each invocation of make, even if they are already up-to-date.

Actions #1

Updated by Electric Monk 10 months ago

  • Gerrit CR set to 1205
Actions #2

Updated by Andy Fiddaman 10 months ago

Tested by doing a full nightly, and then going into the bldenv and running make in the target directory. The output showed each directory being entered, but the targets were not rebuilt.

build:illumos:ig_ksh_FRC% pwd
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast
build:illumos:ig_ksh_FRC% make
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/tools
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libast
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libast/i386
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libast/amd64
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libsum
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libsum/i386
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libsum/amd64
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libcmd
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libcmd/i386
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libcmd/amd64
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libdll
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libdll/i386
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libdll/amd64
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libpp
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libpp/i386
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libshell
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libshell/i386
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/libshell/amd64
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/shcomp
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/ksh
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/ksh/i386
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/ksh/amd64
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/ksh/builtins
/data/omnios-build/omniosorg/bloody/illumos/usr/src/cmd/ast/msgcc
build:illumos:ig_ksh_FRC%

Also ran wsdiff to compare before and after workspaces.

Actions #3

Updated by Electric Monk 10 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 475b46fedca96b852acd24d70191d29fb444a008

commit  475b46fedca96b852acd24d70191d29fb444a008
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2021-02-02T23:18:29.000Z

    13486 cmd/ast should use fewer FRC dependencies
    Reviewed by: Rich Lowe <richlowe@richlowe.net>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF