Project

General

Profile

Actions

Bug #13487

closed

want mapfile-based assertions about symbol properties

Added by Rich Lowe over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

In our constant quest to avoid breaking the ABI, we should assert that any global data is the size we expect both as a check, and a warning to anyone changing it (perhaps inadvertently) that they must consider the repercussions.

We can do this by implementing a version of the Solaris ld(1) mapfile assertions.

Actions #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1214
Actions #2

Updated by Rich Lowe about 1 year ago

testing:

Builds of illumos, additions to the test suite.  Merges with illumos showing up additional/changed global data I've had to adapt to, showing that both the guidance and assertions fire.
Actions #3

Updated by Electric Monk about 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 8222814ef8560ee0ba222eca8ca5acffc6cd0e44

commit  8222814ef8560ee0ba222eca8ca5acffc6cd0e44
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2021-04-09T20:48:05.000Z

    13487 want mapfile-based assertions about symbol properties
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions #4

Updated by Toomas Soome about 1 year ago

SPARC build and testing: building on sparc did reveal issue in libld and additional mapfile entries were needed (as expected). build/install/boot on my build system. Build is also reported by Klaus Ziegler.

Actions #5

Updated by Electric Monk about 1 year ago

git commit 7e85189a2092f2550c3af3a55e22564546838229

commit  7e85189a2092f2550c3af3a55e22564546838229
Author: Toomas Soome <tsoome@me.com>
Date:   2021-04-15T20:46:59.000Z

    13487 want mapfile-based assertions about symbol properties (fix SPARC)
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Klaus Ziegler <klausz@haus-gisela.de>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF