Project

General

Profile

Actions

Bug #13490

closed

4133 missed Makefile.asthdr

Added by Andy Fiddaman 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

#4133 added new variables to Makefile.master for the location of the AST bin directory and msgcc command, but did not use these in Makefile.asthdr
This causes problems building the ast message catalogues on distributions which do not have these in the expected path.


Related issues

Related to illumos gate - Bug #4133: Need a way to specify ast binary directoryResolvedRobert Mustacchi2013-09-14

Actions
Actions #1

Updated by Andy Fiddaman 10 months ago

  • Related to Bug #4133: Need a way to specify ast binary directory added
Actions #2

Updated by Electric Monk 10 months ago

  • Gerrit CR set to 1206
Actions #3

Updated by Andy Fiddaman 10 months ago

Tested by running a full build on OmniOS, which was successful.

Actions #4

Updated by Dan McDonald 10 months ago

Also tested on SmartOS/illumos-joyent pre-integration.

Actions #5

Updated by Electric Monk 10 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 3770e1fa2763b08d66814eeb974a28a87198fee1

commit  3770e1fa2763b08d66814eeb974a28a87198fee1
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2021-02-02T23:19:16.000Z

    13490 4133 missed Makefile.asthdr
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF