Project

General

Profile

Actions

Bug #13492

closed

Makefile.ast could avoid sed's -i option

Added by Andy Fiddaman 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The sed in illumos-gate handles the -i option in a way similar to GNU sed following the integration of #586, but SmartOS reverted that change and has a BSD-style -i option to their sed.

Makefile.ast should avoid using sed -i for broadest compatibility.

Actions #1

Updated by Electric Monk 10 months ago

  • Gerrit CR set to 1210
Actions #2

Updated by Andy Fiddaman 10 months ago

Tested by doing a full build and wsdiff to ensure the results are unchanged.
Also did a dmake _feature in usr/src/cmd/ast followed by a git diff to check that the generated files are the same as before.

Dan McDonald also tested this on SmartOS, building illumos-joyent with this patch and confirmed success.

Actions #3

Updated by Electric Monk 10 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 44ce9f4b5e85893725f9e851530b585072ee8593

commit  44ce9f4b5e85893725f9e851530b585072ee8593
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2021-02-09T22:33:16.000Z

    13492 Makefile.ast could avoid sed's -i option
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF