Project

General

Profile

Actions

Bug #13513

closed

Do not use >; in cmd/ast/tools/Makefile

Added by Andy Fiddaman 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

usr/src/cmd/ast/tools/Makefile uses ksh's >; redirection in an attempt to create the target atomically, and avoid leaving it with partial content.
However, in some circumstances, this does not work and the final rename fails (see #13512).
Note that this does somehow work when running a build with nightly, and often under bldenv (at least in all of the testing I've done for the various ksh changes)

We should just avoid using this construct in the Makefile entirely


Related issues

Related to illumos gate - Bug #13512: ksh's >; is not reliable with `-c'ClosedAndy Fiddaman

Actions
Actions #1

Updated by Andy Fiddaman 10 months ago

  • Related to Bug #13512: ksh's >; is not reliable with `-c' added
Actions #2

Updated by Electric Monk 10 months ago

  • Gerrit CR set to 1225
Actions #3

Updated by Andy Fiddaman 10 months ago

  • Description updated (diff)
Actions #4

Updated by Andy Fiddaman 10 months ago

I've never been able to replicate the issue via nightly or by selectively building in a bldenv on OmniOS, but I've tested that I still get expected results after this change, and used wsdiff to confirm that there are no unexpected changes between builds. The change removes the use of >; entirely so it will solve the initial reported problem.

Actions #5

Updated by Electric Monk 10 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 42757785c4c4da261e053d2c6e2ef6cb2d348a15

commit  42757785c4c4da261e053d2c6e2ef6cb2d348a15
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2021-02-15T16:55:02.000Z

    13513 Do not use >; in cmd/ast/tools/Makefile
    Reviewed by: Rich Lowe <richlowe@richlowe.net>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF