Do not use >; in cmd/ast/tools/Makefile
usr/src/cmd/ast/tools/Makefile uses ksh's
>; redirection in an attempt to create the target atomically, and avoid leaving it with partial content.
However, in some circumstances, this does not work and the final rename fails (see #13512).
Note that this does somehow work when running a build with nightly, and often under bldenv (at least in all of the testing I've done for the various ksh changes)
We should just avoid using this construct in the Makefile entirely
Updated by Andy Fiddaman 11 months ago
I've never been able to replicate the issue via
nightly or by selectively building in a
bldenv on OmniOS, but I've tested that I still get expected results after this change, and used
wsdiff to confirm that there are no unexpected changes between builds. The change removes the use of
>; entirely so it will solve the initial reported problem.
Updated by Electric Monk 11 months ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
commit 42757785c4c4da261e053d2c6e2ef6cb2d348a15 Author: Andy Fiddaman <firstname.lastname@example.org> Date: 2021-02-15T16:55:02.000Z 13513 Do not use >; in cmd/ast/tools/Makefile Reviewed by: Rich Lowe <email@example.com> Approved by: Robert Mustacchi <firstname.lastname@example.org>