Project

General

Profile

Actions

Bug #13516

closed

loader.efi: efifb_mask_from_pixfmt is missing PixelBltOnly

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

GOP protocol may only provide software Blt() and no hardware framebuffer. Such configuration would provide pixel type PixelBltOnly and we need to recognise it while setting up color masks.

Note: this update will fix loader.efi to be able to draw on virtual screens (with no mapped framebuffer). However, out kernel can not use such console because we gfx_private will need mapped framebuffer, if this is the case, only serial console can be used.

Testing done: I did test this with freebsd loader on qemu-system-aarch64 and with -device virtio-gpu-pci.

Actions #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1230
Actions #2

Updated by Toomas Soome over 1 year ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit aeaf55833f532850471446fb8721ef54e0b9a36d

commit  aeaf55833f532850471446fb8721ef54e0b9a36d
Author: Toomas Soome <tsoome@me.com>
Date:   2021-02-16T19:20:19.000Z

    13516 loader.efi: efifb_mask_from_pixfmt is missing PixelBltOnly
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.dev>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF